Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_dimension(dim=bands) => do not filter out all nodata tiles #322

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

jdries
Copy link
Contributor

@jdries jdries commented Sep 19, 2024

do not filter out all nodata tiles, but replace them with 'empty' tile. This avoids issues in subsequent merge_cubes with spatial cube or linear interpolation over time.

WorldCereal/worldcereal-classification#141

… replace them with 'empty' tile. This avoids issues in subsequent merge_cubes with spatial cube or linear interpolation over time.

WorldCereal/worldcereal-classification#141
@jdries jdries self-assigned this Sep 19, 2024
@jdries jdries linked an issue Sep 19, 2024 that may be closed by this pull request
@kvantricht
Copy link

@jdries what would be the timeline to get this in production?

@jdries
Copy link
Contributor Author

jdries commented Sep 23, 2024

@kvantricht unit tests seem to have succeeded, so:

  • if urgent, I can merge immediately
  • if not yet super urgent, it would be better if I manage to cover this with a unit test as well, and then merge

@kvantricht
Copy link

@jdries if this is in production in let's say a week from now, it should be fine for us to still test some things before the webinar 17 October. Probably qualifies as not too urgent then?

@jdries jdries merged commit e46c04a into develop Sep 25, 2024
1 check passed
@jdries jdries deleted the 141_wc_nodatafilter branch September 25, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate NaN pixels in DEM
2 participants